Skip to content

fix(doc): resolve example error for oras tag#1419

Merged
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:tag-example
Jun 20, 2024
Merged

fix(doc): resolve example error for oras tag#1419
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:tag-example

Conversation

@qweeah

@qweeah qweeah commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1418

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Jun 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (0bbd881) to head (ad381b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   85.28%   85.33%   +0.05%     
==========================================
  Files         106      106              
  Lines        3798     3798              
==========================================
+ Hits         3239     3241       +2     
+ Misses        335      333       -2     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 55ca84a into oras-project:main Jun 20, 2024
qweeah added a commit to qweeah/oras that referenced this pull request Dec 5, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added a commit to qweeah/oras that referenced this pull request Dec 5, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added a commit to qweeah/oras that referenced this pull request Dec 5, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oras tag -h shows wrong CLI example

2 participants