Skip to content

fix: ignore --pretty when --output is used for oras manifest fetch#1363

Merged
qweeah merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:no-pretty-on-file
Apr 19, 2024
Merged

fix: ignore --pretty when --output is used for oras manifest fetch#1363
qweeah merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:no-pretty-on-file

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1361

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@codecov

codecov Bot commented Apr 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (22bbd58) to head (97b88cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
- Coverage   84.71%   84.66%   -0.05%     
==========================================
  Files         104      104              
  Lines        3689     3691       +2     
==========================================
  Hits         3125     3125              
- Misses        336      338       +2     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread cmd/oras/root/manifest/fetch.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit db87054 into oras-project:main Apr 19, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the no-pretty-on-file branch April 23, 2024 07:21
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--pretty should not prettify file output

2 participants