chore: project selected fields from OCI descriptor#1362
Merged
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
==========================================
+ Coverage 84.78% 84.80% +0.02%
==========================================
Files 104 104
Lines 3706 3712 +6
==========================================
+ Hits 3142 3148 +6
Misses 336 336
Partials 228 228 ☔ View full report in Codecov by Sentry. |
TerryHowe
reviewed
May 6, 2024
TerryHowe
left a comment
Member
There was a problem hiding this comment.
Would it be easier to exclude fields you don't want?
Contributor
I think OCI image-spec may add more fields in the future. Therefore, an allow list would be easier. |
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR limits the selectable fields of a descriptor in json and template output.