feat: improve error message of when a set of flags is required to use together#1358
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1358 +/- ##
==========================================
+ Coverage 84.71% 84.77% +0.05%
==========================================
Files 104 104
Lines 3691 3704 +13
==========================================
+ Hits 3127 3140 +13
Misses 336 336
Partials 228 228 ☔ View full report in Codecov by Sentry. |
56595cf to
d91ca0b
Compare
qweeah
reviewed
Apr 23, 2024
qweeah
reviewed
Apr 23, 2024
d91ca0b to
eee4e64
Compare
… together Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
eee4e64 to
7fc5040
Compare
qweeah
reviewed
Apr 23, 2024
qweeah
reviewed
Apr 24, 2024
qweeah
reviewed
Apr 24, 2024
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
qweeah
reviewed
Apr 24, 2024
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
shizhMSFT
approved these changes
Apr 29, 2024
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
… together (oras-project#1358) Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
improve error message of when a set of flags is required to use together
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1357
Please check the following list: