refactor: move logger method to command#1355
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
=======================================
Coverage 84.77% 84.78%
=======================================
Files 104 105 +1
Lines 3704 3706 +2
=======================================
+ Hits 3140 3142 +2
Misses 336 336
Partials 228 228 ☔ View full report in Codecov by Sentry. |
qweeah
approved these changes
Apr 19, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM, need to add doc comment for the public function.
Signed-off-by: Terry Howe <tlhowe@amazon.com>
e8850d3 to
fb5afb4
Compare
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
Signed-off-by: Terry Howe <tlhowe@amazon.com> Co-authored-by: Billy Zha <jinzha1@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I think it makes a lot more sense that a command has-a logger rather than an option.