Skip to content

fix: fix error message when output is used before format for oras discover#1354

Merged
qweeah merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:discover-err-msg
Apr 18, 2024
Merged

fix: fix error message when output is used before format for oras discover#1354
qweeah merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:discover-err-msg

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1348

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@wangxiaoxuan273 wangxiaoxuan273 changed the title fix: fix error message when output is used before format fix: fix error message when output is used before format for oras discover Apr 17, 2024
@codecov

codecov Bot commented Apr 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (2edebad) to head (dd18fa0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   84.65%   84.64%   -0.01%     
==========================================
  Files         104      104              
  Lines        3688     3687       -1     
==========================================
- Hits         3122     3121       -1     
  Misses        338      338              
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

Comment thread cmd/oras/internal/errors/errors.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 23e243b into oras-project:main Apr 18, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the discover-err-msg branch April 18, 2024 07:23
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
…cover (oras-project#1354)

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oras discover shows wrong error message

3 participants