Skip to content

feat: add color to progress mark and bar#1344

Merged
qweeah merged 4 commits into
oras-project:mainfrom
qweeah:progress-color
Apr 15, 2024
Merged

feat: add color to progress mark and bar#1344
qweeah merged 4 commits into
oras-project:mainfrom
qweeah:progress-color

Conversation

@qweeah

@qweeah qweeah commented Apr 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds color to the TTY output.

  • The spinner will be renderred in light yellow
  • The done mark will be renderred in light green
  • The progress bar will be renderred in light blue

image

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah
feat: add color to progress mark and bar
cb6d39a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added 2 commits April 15, 2024 04:47
@qweeah
fix unit test
59eccdd 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix ut
5d9d9a9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Apr 15, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (202bcf4) to head (0f6e9e2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1344   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         103      103           
  Lines        3647     3649    +2     
=======================================
+ Hits         3081     3083    +2     
  Misses        338      338           
  Partials      228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT reviewed Apr 15, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/progress/status.go
Comment thread cmd/oras/internal/display/status/progress/status.go Outdated
@qweeah
resolve comment
0f6e9e2 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Apr 15, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit cc74e50 into oras-project:main Apr 15, 2024
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@qweeah @FeynmanZhou
feat: add color to progress mark and bar (oras-project#1344)
275dde6 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qweeah @shizhMSFT