Skip to content

feat: oras discover should show a placeholder of artifactType if it's not presented#1336

Merged
qweeah merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:discover
Apr 12, 2024
Merged

feat: oras discover should show a placeholder of artifactType if it's not presented#1336
qweeah merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:discover

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
current display
image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1108

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov

codecov Bot commented Apr 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (91268a2) to head (fb3c094).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   84.34%   84.35%           
=======================================
  Files         101      101           
  Lines        3615     3617    +2     
=======================================
+ Hits         3049     3051    +2     
  Misses        337      337           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 9732d14 into oras-project:main Apr 12, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the discover branch April 15, 2024 02:58
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
… not presented (oras-project#1336)

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oras discover should show a placeholder of artifactType if it's not presented in an index referrer

2 participants