Skip to content

ux: improve the usage doc of --image-spec#1334

Merged
qweeah merged 7 commits into
oras-project:mainfrom
wangxiaoxuan273:help-info
Apr 11, 2024
Merged

ux: improve the usage doc of --image-spec#1334
qweeah merged 7 commits into
oras-project:mainfrom
wangxiaoxuan273:help-info

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

auto option for --image-spec is removed.

current display of --image-spec help info:
image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1061

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@codecov

codecov Bot commented Apr 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (1494475) to head (6292d7e).

❗ Current head 6292d7e differs from pull request most recent head f46b46c. Consider uploading reports for the commit f46b46c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
- Coverage   84.41%   84.40%   -0.01%     
==========================================
  Files          97       97              
  Lines        3541     3540       -1     
==========================================
- Hits         2989     2988       -1     
  Misses        329      329              
  Partials      223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangxiaoxuan273 wangxiaoxuan273 marked this pull request as ready for review April 10, 2024 06:53
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Comment thread cmd/oras/internal/option/spec.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Comment thread cmd/oras/internal/option/spec.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit b5217ef into oras-project:main Apr 11, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the help-info branch April 15, 2024 02:59
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show artifact type when pushing files

3 participants