fix: oras push should return error when artifacttype is empty for spec 1.1#1317
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 84.06% 84.10% +0.04%
==========================================
Files 90 90
Lines 3458 3467 +9
==========================================
+ Hits 2907 2916 +9
Misses 329 329
Partials 222 222 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
There are 3 issues to discuss:
|
qweeah
reviewed
Apr 2, 2024
qweeah
reviewed
Apr 2, 2024
qweeah
reviewed
Apr 2, 2024
qweeah
reviewed
Apr 2, 2024
qweeah
reviewed
Apr 2, 2024
qweeah
requested changes
Apr 2, 2024
qweeah
reviewed
Apr 3, 2024
qweeah
reviewed
Apr 8, 2024
1 task
shizhMSFT
reviewed
Apr 8, 2024
…c 1.1 Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
…c 1.1 (oras-project#1317) Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
oras pushshould return an error when--configis used,--artifact-typeis not used and--image-specis set tov1.1.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1313
Please check the following list: