Skip to content

chore: using const to replace string#1316

Merged
qweeah merged 2 commits into
oras-project:mainfrom
LinuxSuRen:chore/using-const
Apr 1, 2024
Merged

chore: using const to replace string#1316
qweeah merged 2 commits into
oras-project:mainfrom
LinuxSuRen:chore/using-const

Conversation

@LinuxSuRen

Copy link
Copy Markdown
Contributor

Signed-off-by: rick LinuxSuRen@users.noreply.github.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: rick <LinuxSuRen@users.noreply.github.com>
@codecov

codecov Bot commented Mar 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (bf18775) to head (44301c3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
- Coverage   82.35%   82.30%   -0.05%     
==========================================
  Files          83       83              
  Lines        4036     4036              
==========================================
- Hits         3324     3322       -2     
- Misses        492      494       +2     
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah

qweeah commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

Thanks for contributing @LinuxSuRen.

@qweeah qweeah merged commit c24ac15 into oras-project:main Apr 1, 2024
@LinuxSuRen LinuxSuRen deleted the chore/using-const branch April 1, 2024 02:08
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: rick <LinuxSuRen@users.noreply.github.com>
Co-authored-by: rick <LinuxSuRen@users.noreply.github.com>
Co-authored-by: Terry Howe <tlhowe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants