Skip to content

refactor: use command output in status output#1314

Merged
qweeah merged 12 commits into
oras-project:mainfrom
qweeah:status-printer
Mar 29, 2024
Merged

refactor: use command output in status output#1314
qweeah merged 12 commits into
oras-project:mainfrom
qweeah:status-printer

Conversation

@qweeah

@qweeah qweeah commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

This PR makes status output handlers use command output.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added 3 commits March 28, 2024 08:09
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Mar 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.30%. Comparing base (093ed14) to head (e8e3e44).

Files Patch % Lines
cmd/oras/internal/display/status/text.go 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
+ Coverage   82.27%   82.30%   +0.03%     
==========================================
  Files          83       83              
  Lines        4029     4036       +7     
==========================================
+ Hits         3315     3322       +7     
  Misses        494      494              
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah added 8 commits March 28, 2024 08:26
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit bf18775 into oras-project:main Mar 29, 2024
@TerryHowe

Copy link
Copy Markdown
Member

Yeh, that is an improvement, thanks

FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants