bump: bump `oras-go` to 2.5.0 by wangxiaoxuan273 · Pull Request #1303 · oras-project/oras

wangxiaoxuan273 · 2024-03-22T08:26:33Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1275
Fixes #1304

Please check the following list:

Does the affected code have corresponding tests, e.g. unit test, E2E test?
Does this change require a documentation update?
Does this introduce breaking changes that would require an announcement or bumping the major version?
Do all new files have an appropriate license header?

shizhMSFT

The build and the lint failed.

The build failure is due to the E2E test failure caused by a bug in checking the reference for oci-layout (check line 77).

oras/cmd/oras/root/tag.go

Lines 75 to 82 in e8da6e5

    
           PreRunE: func(cmd *cobra.Command, args []string) error { 
        
           	opts.RawReference = args[0] 
        
           	if _, err := registry.ParseReference(opts.RawReference); err != nil { 
        
           		return fmt.Errorf("unable to add tag for '%s': %w", opts.RawReference, err) 
        
           	} 
        
           	opts.targetRefs = args[1:] 
        
           	return option.Parse(&opts) 
        
           },

qweeah · 2024-03-25T03:01:38Z

@shizhMSFT is right, you need to 1) handle all invalid reference error in tag list reflecting #1058; 2) improve target.Parse to accommodate changes in oras-go.

qweeah · 2024-03-25T03:03:20Z

Also need to refactor reference parsing for OCI image layout and do it in target.Parse, so unable to add tag for '%s' can be printed for OCI layout

shizhMSFT

This PR covers #1307 but does not cover #1306

codecov · 2024-03-25T06:48:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (24c2acf) to head (39155e8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
+ Coverage   82.10%   82.27%   +0.16%     
==========================================
  Files          83       83              
  Lines        4030     4029       -1     
==========================================
+ Hits         3309     3315       +6     
+ Misses        498      494       -4     
+ Partials      223      220       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah

Since this PR also fixes #1304, we also need to enhance E2E tests.

wangxiaoxuan273 · 2024-03-25T10:19:42Z

Since this PR also fixes #1304, we also need to enhance E2E tests.

Added a test case for #1304

qweeah

LGTM

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com> increase coverage resolve comment Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

shizhMSFT

LGTM with suggestions

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

shizhMSFT

LGTM

qweeah

LGTM

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

wangxiaoxuan273 requested review from SteveLasker, TerryHowe, qweeah, sajayantony and shizhMSFT as code owners March 22, 2024 08:26

shizhMSFT requested changes Mar 22, 2024

View reviewed changes

shizhMSFT requested changes Mar 25, 2024

View reviewed changes

This was referenced Mar 25, 2024

build(deps): bump oras.land/oras-go/v2 from 2.4.0 to 2.5.0 #1307

Closed

build(deps): bump oras.land/oras-go/v2 from 2.4.0 to 2.5.0 in /test/e2e #1306

Closed

wangxiaoxuan273 force-pushed the bump branch from 9723c49 to 82b8925 Compare March 25, 2024 06:55

qweeah requested changes Mar 25, 2024

View reviewed changes

Comment thread cmd/oras/internal/option/target.go Outdated

Comment thread cmd/oras/internal/option/target.go Outdated

wangxiaoxuan273 force-pushed the bump branch 2 times, most recently from 4c4f143 to fc8679d Compare March 25, 2024 08:54

qweeah requested changes Mar 25, 2024

View reviewed changes

Comment thread cmd/oras/internal/option/target.go Outdated

Comment thread cmd/oras/internal/option/target.go

Comment thread cmd/oras/internal/option/target.go Outdated

Comment thread cmd/oras/internal/option/target.go Outdated

qweeah approved these changes Mar 26, 2024

View reviewed changes

shizhMSFT requested changes Mar 27, 2024

View reviewed changes

Comment thread cmd/oras/internal/option/target.go Outdated

Comment thread cmd/oras/internal/option/target.go Outdated

Comment thread cmd/oras/root/tag.go

wangxiaoxuan273 added 10 commits March 28, 2024 05:57

bump: bump oras-go to 2.5.0

2aaa87c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fix failed e2e test

12d4482

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fix e2e test case

6ab99c4

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fix lint

c6c05d4

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

revert change

c7392f1

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fix one failed test

582dd58

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

changed tag and target

7c3e23c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fix failed unit test

e2b7722

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

clean up

668a75c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

add error wrap for target

c7fe082

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com> increase coverage resolve comment Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

wangxiaoxuan273 added 7 commits March 28, 2024 05:57

resolved comments

9dd1d99

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

test attempt

c7c52e4

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

retag test

ca95a11

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

refined

40e4e75

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolved comments

87d6805

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

resolve comments

03f7ca5

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

fix e2e

853756c

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

wangxiaoxuan273 force-pushed the bump branch from 80b2a3b to 853756c Compare March 28, 2024 06:02

shizhMSFT approved these changes Mar 28, 2024

View reviewed changes

Comment thread cmd/oras/internal/option/target.go Outdated

Comment thread cmd/oras/internal/option/target.go Outdated

resolve comments

39155e8

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

shizhMSFT approved these changes Mar 28, 2024

View reviewed changes

qweeah approved these changes Mar 28, 2024

View reviewed changes

qweeah merged commit 093ed14 into oras-project:main Mar 28, 2024

wangxiaoxuan273 deleted the bump branch March 28, 2024 07:56

qweeah mentioned this pull request Apr 16, 2024

Windows unit tests cannot be compiled #1347

Closed

FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024

bump: bump oras-go to 2.5.0 (oras-project#1303)

2f8d62d

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

qweeah mentioned this pull request May 14, 2024

bump: tag and release ORAS CLI v1.2.0-rc.1 #1381

Merged

	PreRunE: func(cmd *cobra.Command, args []string) error {
	opts.RawReference = args[0]
	if _, err := registry.ParseReference(opts.RawReference); err != nil {
	return fmt.Errorf("unable to add tag for '%s': %w", opts.RawReference, err)
	}
	opts.targetRefs = args[1:]
	return option.Parse(&opts)
	},

Conversation

wangxiaoxuan273 commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

qweeah commented Mar 25, 2024

Uh oh!

qweeah commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qweeah left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wangxiaoxuan273 commented Mar 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qweeah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shizhMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

qweeah left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wangxiaoxuan273 commented Mar 22, 2024 •

edited

Loading

qweeah commented Mar 25, 2024 •

edited

Loading

codecov Bot commented Mar 25, 2024 •

edited

Loading

qweeah left a comment •

edited

Loading