Skip to content

feat: support --format in manifest fetch command#1295

Merged
qweeah merged 46 commits into
oras-project:mainfrom
qweeah:format-manifest-fetch
Apr 10, 2024
Merged

feat: support --format in manifest fetch command#1295
qweeah merged 46 commits into
oras-project:mainfrom
qweeah:format-manifest-fetch

Conversation

@qweeah

@qweeah qweeah commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR add --format flag to manifest fetch command to support field formatting for OCI manifests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #638

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

qweeah added 2 commits March 18, 2024 09:56
@qweeah
feat: support --format in manifest fetch command
67dad87 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add comment
fa0f2a1 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review March 18, 2024 10:07
@codecov

codecov Bot commented Mar 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.65979% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.46%. Comparing base (85fbdab) to head (4ec65f9).

Files Patch % Lines
...md/oras/internal/display/content/manifest_fetch.go 85.71% 1 Missing and 1 partial ⚠️
...rnal/display/metadata/descriptor/manifest_fetch.go 77.77% 1 Missing and 1 partial ⚠️
...s/internal/display/metadata/json/manifest_fetch.go 75.00% 1 Missing and 1 partial ⚠️
...ternal/display/metadata/template/manifest_fetch.go 77.77% 1 Missing and 1 partial ⚠️
cmd/oras/internal/display/utils/utils.go 77.77% 1 Missing and 1 partial ⚠️
cmd/oras/root/manifest/fetch.go 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
+ Coverage   84.04%   84.46%   +0.41%     
==========================================
  Files          90       97       +7     
  Lines        3467     3541      +74     
==========================================
+ Hits         2914     2991      +77     
+ Misses        331      327       -4     
- Partials      222      223       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TerryHowe
TerryHowe reviewed Mar 18, 2024
View reviewed changes
Comment thread cmd/oras/root/manifest/fetch.go
Comment thread cmd/oras/root/manifest/fetch.go
shizhMSFT
shizhMSFT reviewed Mar 22, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/metadata/template/manifest_fetch.go Outdated
shizhMSFT
shizhMSFT requested changes Mar 22, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/metadata/interface.go Outdated
Comment thread cmd/oras/root/manifest/fetch.go Outdated
Comment thread cmd/oras/root/manifest/fetch.go
Comment thread cmd/oras/root/manifest/fetch.go
qweeah added 17 commits April 1, 2024 03:35
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
fc2bccc
@qweeah
refactor
e9c1226 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
9c73b0d
@qweeah
use new printer
6614c92 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
bug fix
eb5f62d 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix struct fields with json tags
ce6bc89 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
5dc8583
@qweeah
remove raw discarder
c13ee29 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
4b1e2f9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
5689580
@qweeah
fix e2e
c7488d6 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor
42ab0a3 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add discard handler for raw output
d954405 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
00a5895 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
revert focus
7460060 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
rename to content handler
de6acf1 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
4709b62 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added 10 commits April 8, 2024 06:29
@qweeah
code clean
ca0f082 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comments
a1addb4 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
998ad76 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
f93ba89 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
e66ed8e
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
a7656be
@qweeah
code clean
b54a2e6 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
e682458 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
faa8c63 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'upstream/main' into format-manifest-fetch
9c3a426
shizhMSFT
shizhMSFT reviewed Apr 9, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/utils/utils.go Outdated
Comment thread cmd/oras/internal/option/pretty.go
Comment thread cmd/oras/internal/display/handler.go Outdated
Comment thread cmd/oras/internal/display/handler.go Outdated
Comment thread cmd/oras/internal/display/metadata/discard.go Outdated
Comment thread cmd/oras/root/manifest/fetch.go Outdated
qweeah added 7 commits April 10, 2024 01:38
@qweeah
add fetched model
4eb5b9f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add experimental mark
3cbbf9b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
7b09792 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
cb98a26 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comments
6615478 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add json test
a8c3de8 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
1dfd284 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT reviewed Apr 10, 2024
View reviewed changes
Comment thread cmd/oras/root/manifest/fetch.go Outdated
Comment thread cmd/oras/internal/display/metadata/template/manifest_fetch.go Outdated
Comment thread cmd/oras/internal/display/metadata/json/manifest_fetch.go Outdated
Comment thread cmd/oras/internal/display/metadata/template/manifest_fetch.go Outdated
@qweeah
resolve comments
dfb8dce 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT reviewed Apr 10, 2024
View reviewed changes
Comment thread cmd/oras/root/manifest/fetch.go Outdated
@qweeah
resolve comments
6c5e2cf 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
qweeah commented Apr 10, 2024
View reviewed changes
Comment thread cmd/oras/root/manifest/fetch.go
qweeah added 3 commits April 10, 2024 08:01
@qweeah
add e2e coverage
bb69b39 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove used code
57d2078 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
use create file instead of open file
4ec65f9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Apr 10, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 1494475 into oras-project:main Apr 10, 2024
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@qweeah @FeynmanZhou
feat: support --format in manifest fetch command (oras-project#1295)
e5ac9d9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TerryHowe TerryHowe TerryHowe left review comments

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qweeah @TerryHowe @shizhMSFT