Skip to content

build(actions): update github actions for Node 20#1287

Merged
qweeah merged 4 commits into
oras-project:mainfrom
TerryHowe:github-actions
Mar 15, 2024
Merged

build(actions): update github actions for Node 20#1287
qweeah merged 4 commits into
oras-project:mainfrom
TerryHowe:github-actions

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Node 16 is deprecated and the v3 actions use it. These actions are available with a Node 20 runner with v4.

Signed-off-by: Terry Howe <tlhowe@amazon.com>
@codecov

codecov Bot commented Mar 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (ec23755) to head (54cbb39).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
+ Coverage   81.99%   84.49%   +2.49%     
==========================================
  Files          83       83              
  Lines        4005     3276     -729     
==========================================
- Hits         3284     2768     -516     
+ Misses        498      285     -213     
  Partials      223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah

qweeah commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

@TerryHowe Can you help make the PR title complaint to conventional commits? E.g. for this PR it can be build(actions): update to Node 20

@TerryHowe TerryHowe changed the title Update github actions for Node 20 build(actions): Update github actions for Node 20 Mar 14, 2024
@qweeah qweeah changed the title build(actions): Update github actions for Node 20 build(actions): update github actions for Node 20 Mar 15, 2024

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 61a8f49 into oras-project:main Mar 15, 2024
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Terry Howe <tlhowe@amazon.com>
@TerryHowe TerryHowe deleted the github-actions branch May 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants