refactor: pass cobra.Command to all cmd exec functions#1285
Merged
Conversation
Signed-off-by: Terry Howe <tlhowe@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
- Coverage 81.92% 81.90% -0.03%
==========================================
Files 83 83
Lines 3995 3996 +1
==========================================
Hits 3273 3273
- Misses 499 500 +1
Partials 223 223 ☔ View full report in Codecov by Sentry. |
Contributor
|
@TerryHowe Can you help make the PR title complaint to conventional commits? E.g. for this PR it can be |
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
…1285) Signed-off-by: Terry Howe <tlhowe@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a minor refactor to make the command private methods consistent. Most of them take a cmd and not a context except for these six. The reason for this is to make logging and output more consistent across the commands and the
corbra.Commandhas methods likeOutOrStdoutWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: