Skip to content

chore: improve error message if the provided annotation file is invalid#1255

Merged
qweeah merged 1 commit into
oras-project:mainfrom
wangxiaoxuan273:p2-1214
Jan 29, 2024
Merged

chore: improve error message if the provided annotation file is invalid#1255
qweeah merged 1 commit into
oras-project:mainfrom
wangxiaoxuan273:p2-1214

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part 2 of #1214

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 wangxiaoxuan273 changed the title chore: improve err msg chore: improve error message if the provided annotation file is invalid Jan 29, 2024
@codecov

codecov Bot commented Jan 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33dd0b0) 81.71% compared to head (d746ce6) 81.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   81.71%   81.70%   -0.01%     
==========================================
  Files          68       68              
  Lines        3812     3810       -2     
==========================================
- Hits         3115     3113       -2     
  Misses        489      489              
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 06097c0 into oras-project:main Jan 29, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the p2-1214 branch January 29, 2024 06:01
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
…id (oras-project#1255)

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants