Skip to content

chore(ux): improve error message for bad annotation format#1243

Merged
qweeah merged 1 commit into
oras-project:mainfrom
wangxiaoxuan273:annotation
Jan 19, 2024
Merged

chore(ux): improve error message for bad annotation format#1243
qweeah merged 1 commit into
oras-project:mainfrom
wangxiaoxuan273:annotation

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1215

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

current display:
image

@qweeah

qweeah commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

Changes is aligned with the PRD but you need to fix the unit tests

@codecov

codecov Bot commented Jan 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d21c31f) 81.44% compared to head (c86ff51) 81.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
+ Coverage   81.44%   81.46%   +0.01%     
==========================================
  Files          68       68              
  Lines        3746     3749       +3     
==========================================
+ Hits         3051     3054       +3     
  Misses        487      487              
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread cmd/oras/internal/option/packer.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 0514a57 into oras-project:main Jan 19, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the annotation branch January 19, 2024 09:12
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
…ect#1243)

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve error message when pushing with invalid annotation flags

2 participants