Skip to content

chore(ux): improve error message for oras manifest push#1241

Merged
qweeah merged 11 commits into
oras-project:mainfrom
wangxiaoxuan273:manifest-push
Jan 19, 2024
Merged

chore(ux): improve error message for oras manifest push#1241
qweeah merged 11 commits into
oras-project:mainfrom
wangxiaoxuan273:manifest-push

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1212

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

current display:
image

@wangxiaoxuan273 wangxiaoxuan273 changed the title chore: improve error message chore(ux): improve error message for oras manifest push Jan 15, 2024
@codecov

codecov Bot commented Jan 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ca087a) 81.44% compared to head (6de1b96) 81.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   81.44%   81.44%           
=======================================
  Files          67       68    +1     
  Lines        3740     3746    +6     
=======================================
+ Hits         3046     3051    +5     
- Misses        486      487    +1     
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread cmd/oras/internal/parse/parse.go Outdated
Comment thread cmd/oras/internal/parse/parse.go Outdated
Comment thread cmd/oras/root/manifest/push.go Outdated
Comment thread cmd/oras/internal/parse/parse_test.go Outdated

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread cmd/oras/internal/parse/parse.go Outdated
Comment thread cmd/oras/internal/parse/parse.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit d21c31f into oras-project:main Jan 19, 2024
wangxiaoxuan273 added a commit to wangxiaoxuan273/oras that referenced this pull request Jan 19, 2024
…#1241)

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273 wangxiaoxuan273 deleted the manifest-push branch January 19, 2024 09:12
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
…#1241)

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve error message when pushing a manifest without media type

3 participants