chore(ux): improve error message for oras manifest fetch#1234
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
+ Coverage 81.08% 81.44% +0.35%
==========================================
Files 67 67
Lines 3727 3740 +13
==========================================
+ Hits 3022 3046 +24
+ Misses 494 486 -8
+ Partials 211 208 -3 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Jan 8, 2024
qweeah
reviewed
Jan 8, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
requested changes
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 12, 2024
qweeah
reviewed
Jan 15, 2024
qweeah
approved these changes
Jan 15, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestion.
Contributor
|
I just merged another PR, @wangxiaoxuan273 can you help resolve the conflicts? |
47606e3 to
fdbc3e9
Compare
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
fdbc3e9 to
9857173
Compare
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
…t#1234) Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
improve error message for oras manifest fetch
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1211 and #1233
Please check the following list:
Current display:
