Skip to content

fix: resolve error in help doc of distribution spec flag#1229

Merged
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:fix-spec
Jan 4, 2024
Merged

fix: resolve error in help doc of distribution spec flag#1229
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:fix-spec

Conversation

@qweeah

@qweeah qweeah commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1225. Current output after fix

$ oras attach -h
...
 --distribution-spec string                   [Preview] set OCI distribution spec version and API option for target. Options: v1.1-referrers-tag, v1.1-referrers-api
...

$ oras cp -h
...
 --from-distribution-spec string                   [Preview] set OCI distribution spec version and API option for source target. Options: v1.1-referrers-tag, v1.1-referrers-api
...
 --to-distribution-spec string                     [Preview] set OCI distribution spec version and API option for destination target. Options: v1.1-referrers-tag, v1.1-referrers-api
...

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah
fix: resolve error in help doc of distribution spec flag
e970273 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Jan 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (564bd32) 80.65% compared to head (e970273) 80.59%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
- Coverage   80.65%   80.59%   -0.06%     
==========================================
  Files          67       67              
  Lines        3644     3644              
==========================================
- Hits         2939     2937       -2     
- Misses        493      495       +2     
  Partials      212      212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT approved these changes Jan 4, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 3af1cd3 into oras-project:main Jan 4, 2024
@qweeah qweeah mentioned this pull request Feb 1, 2024
Merged
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@qweeah @FeynmanZhou
fix: resolve error in help doc of distribution spec flag (oras-projec…
0df161f 
…t#1229)

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Help message is not properly rendered for oras attach

2 participants

@qweeah @shizhMSFT