Skip to content

chore(ux): show registry error and hint for dockehub#1222

Merged
qweeah merged 46 commits into
oras-project:mainfrom
qweeah:docker-error
Jan 16, 2024
Merged

chore(ux): show registry error and hint for dockehub#1222
qweeah merged 46 commits into
oras-project:mainfrom
qweeah:docker-error

Conversation

@qweeah

@qweeah qweeah commented Dec 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR

  1. adds prefix to errors returned by registry. E.g. invalid creds for fetching a manifest
$ oras manifest fetch-config localhost:7000/repo:tag -u hello -p 123 >>
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Error response from registry: unauthorized: authentication required
  1. gives recommendation if namespace is missing in a Dockerhub reference.
$ oras pull docker.io/apline:latest
Error response from registry: failed to resolve latest: unauthorized: authentication required: [map[Action:pull Class: Name:apline Type:repository]]
Namespace is missing, do you mean `oras pull docker.io/library/apline:latest`?

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1216

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah
chore(ux): show registry error and hint for dockehub
5dd63fd 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
6994167 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as draft December 28, 2023 08:15
@qweeah
support not found error
3c10c7d 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Dec 29, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (04f0c33) 80.65% compared to head (e602b89) 81.03%.

Files Patch % Lines
cmd/oras/internal/errors/errors.go 90.90% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   80.65%   81.03%   +0.37%     
==========================================
  Files          67       67              
  Lines        3644     3727      +83     
==========================================
+ Hits         2939     3020      +81     
- Misses        493      496       +3     
+ Partials      212      211       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah added 21 commits December 29, 2023 07:47
@qweeah
Merge remote-tracking branch 'origin_src/main' into docker-error
b0fa65a
@qweeah
support oras ls and oras pull
0925a45 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add e2e test
11cb9cf 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
dbdaa59 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add error test for pull
c19a844 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add unit test
354df3e 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
support error prefix in cp and resolve
20e23e3 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
support push
8594411 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'origin_src/main' into docker-error
fdb5d96
@qweeah
fix e2e
6d0a533 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
scrub debug info & handle empty response body
317556b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
4076635 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
1d3fefa 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
1c01b0a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
937d80c 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'origin_src/main' into docker-error
d905d0f
@qweeah
support all commands and add e2e
ae3dd7b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
bug fix
70ac3a0 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
improve readability
92588f5 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve empty resp body
668152d 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve e2e
fa3adf1 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added 3 commits January 8, 2024 03:23
@qweeah
code clean
cc42b04 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
666c518 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
028beb0 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review January 8, 2024 04:03
@qweeah qweeah mentioned this pull request Jan 9, 2024
Merged
4 tasks
shizhMSFT
shizhMSFT reviewed Jan 9, 2024
View reviewed changes
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/option/remote.go Outdated
qweeah added 3 commits January 9, 2024 03:38
@qweeah
resolve comment
716e62a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
4503268 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
bug fix
9d299a9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT reviewed Jan 9, 2024
View reviewed changes
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/option/remote.go Outdated
Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/option/target.go Outdated
qweeah added 13 commits January 9, 2024 15:24
@qweeah
resolve comments
3607c16 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comments
a9664b3 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
bug fix
0131f02 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add coverage
e47e0d3 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add unit test
0494f77 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix e2e
19b7ec1 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix full reference match and add UT
e530def 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
cover more
ff6a9ba 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
b12d29e 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add TODO
ce2582a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add coverage
7c99330 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
increase coverage
162a9dc 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor trimming
c15c3f5 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jan 15, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

Comment thread cmd/oras/internal/errors/errors.go Outdated
Comment thread cmd/oras/internal/option/target.go Outdated
qweeah added 3 commits January 15, 2024 08:29
@qweeah
resolve comments
ddc9794 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'origin_src/main' into docker-error
af4601a
@qweeah
fix unit test
e602b89 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah merged commit 5bb6c76 into oras-project:main Jan 16, 2024
@qweeah qweeah mentioned this pull request Feb 1, 2024
Merged
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@qweeah @FeynmanZhou
chore(ux): show registry error and hint for Dockerhub (oras-project#1222
44f6668 
)

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

improve error message when namespace is not specified in the reference of Dockerhub artifacts

2 participants

@qweeah @shizhMSFT