Skip to content

build(ci): enforce coverage check#1220

Merged
qweeah merged 5 commits into
oras-project:mainfrom
qweeah:cov-check
Dec 29, 2023
Merged

build(ci): enforce coverage check#1220
qweeah merged 5 commits into
oras-project:mainfrom
qweeah:cov-check

Conversation

@qweeah

@qweeah qweeah commented Dec 26, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This enforces the test coverage check by 75% lines per project

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Dec 26, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (040c11c) 79.83% compared to head (609d141) 79.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1220   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files          67       67           
  Lines        3695     3695           
=======================================
  Hits         2950     2950           
  Misses        526      526           
  Partials      219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as draft December 26, 2023 11:02
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review December 26, 2023 12:06
@qweeah qweeah marked this pull request as draft December 26, 2023 12:21
Comment thread .github/codecov.yml
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review December 28, 2023 08:30

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit c1a3185 into oras-project:main Dec 29, 2023
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants