Skip to content

fix: bug in pushing with multiple tags#1209

Merged
qweeah merged 7 commits into
oras-project:mainfrom
qweeah:fix-push-tag
Dec 25, 2023
Merged

fix: bug in pushing with multiple tags#1209
qweeah merged 7 commits into
oras-project:mainfrom
qweeah:fix-push-tag

Conversation

@qweeah

@qweeah qweeah commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR fixed the bug mentioned in #1208 with minimal refactoring on getTrackedTarget

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Dec 22, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.85%. Comparing base (4aca01f) to head (b38a5f8).
⚠️ Report is 474 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/root/push.go 42.30% 11 Missing and 4 partials ⚠️
cmd/oras/root/pull.go 30.00% 3 Missing and 4 partials ⚠️
cmd/oras/internal/display/track/target.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   80.16%   79.85%   -0.31%     
==========================================
  Files          67       67              
  Lines        3681     3684       +3     
==========================================
- Hits         2951     2942       -9     
- Misses        515      524       +9     
- Partials      215      218       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread cmd/oras/internal/display/track/target.go Outdated
Comment thread cmd/oras/root/pull.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 03ff401 into oras-project:main Dec 25, 2023
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants