Skip to content

test(e2e): add spec to cover legacy docker config file#1206

Merged
qweeah merged 5 commits into
oras-project:mainfrom
qweeah:test-legacy-config
Dec 21, 2023
Merged

test(e2e): add spec to cover legacy docker config file#1206
qweeah merged 5 commits into
oras-project:mainfrom
qweeah:test-legacy-config

Conversation

@qweeah

@qweeah qweeah commented Dec 19, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds a new e2e test spec to cover legacy docker config file.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1204

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad47ec0) 80.30% compared to head (6327db4) 80.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
- Coverage   80.30%   80.06%   -0.25%     
==========================================
  Files          66       66              
  Lines        3646     3646              
==========================================
- Hits         2928     2919       -9     
- Misses        503      513      +10     
+ Partials      215      214       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread .github/licenserc.yml Outdated

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit a377128 into oras-project:main Dec 21, 2023
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
…1206)

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants