build(ci): release artifacts for freebsd by kranurag7 · Pull Request #1192 · oras-project/oras

kranurag7 · 2023-11-23T19:40:16Z

Adds support for oras on freebsd os. It adds make target for compiling oras binary on freebsd and updates goreleaser config to release for freebsd as well.

Note

I've not tested it on a freebsd system. I only tested go compiling the program to an executable.

make targets

$ make build-freebsd
GOARCH=amd64 CGO_ENABLED=0 GOOS=freebsd go build -v --ldflags="-w -X oras.land/oras/internal/version.GitCommit=9ecf303eeb2620dfe3ddf15721999d1f7e8fd4bf -X oras.land/oras/internal/version.GitTreeState=dirty" \
	-o bin/freebsd/amd64/oras oras.land/oras/cmd/oras
$ file bin/freebsd/amd64/oras
bin/freebsd/amd64/oras: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), statically linked, for FreeBSD 12.3, FreeBSD-style, Go BuildID=nJPfJNS3LfJNcKUnioi_/X0yuGUxMlHdwTByT063Y/VfH381P8Oh6iX6eAu6qc/FP_dvr9XPXmKk77-JLXA, not stripped

goreleaser snapshot

$ goreleaser release --snapshot
# truncated 
    • creating                                       archive=dist/oras_1.1.0-SNAPSHOT-9ecf303_freebsd_amd64.tar.gz
$ file dist/oras_freebsd_amd64_v1/oras
dist/oras_freebsd_amd64_v1/oras: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), statically linked, for FreeBSD 12.3, FreeBSD-style, stripped
$ tar -tf dist/oras_1.1.0-SNAPSHOT-9ecf303_freebsd_amd64.tar.gz
LICENSE
oras

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1179

Please check the following list:

Does the affected code have corresponding tests, e.g. unit test, E2E test?
Does this change require a documentation update?
Does this introduce breaking changes that would require an announcement or bumping the major version?
Do all new files have an appropriate license header?

this commit adds support for oras on freebsd os. It adds make target for compiling oras binary on freebsd and updates goreleaser config to release for freebsd as well. Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>

codecov-commenter · 2023-11-23T19:42:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (616c3e1) 81.68% compared to head (3f5424f) 81.73%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
+ Coverage   81.68%   81.73%   +0.05%     
==========================================
  Files          68       68              
  Lines        3806     3806              
==========================================
+ Hits         3109     3111       +2     
+ Misses        489      487       -2     
  Partials      208      208

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rchincha · 2023-12-05T22:49:36Z

cc: @dfr

dfr · 2023-12-06T08:30:16Z

cc: @dfr

I can test this on a FreeBSD system - I'll take a look later today.

FeynmanZhou · 2023-12-06T09:17:33Z

Thank you @rchincha and @dfr !

dfr · 2023-12-06T14:41:10Z

Looks good to me - it builds on FreeBSD natively and that build works well in my ad-hoc testing. I also ran unit tests on a FreeBSD host and that looks fine too.

TerryHowe

/lgtm

dfr · 2023-12-07T08:17:11Z

It would be nice to have arm64 binaries as well but I haven't tested that so perhaps that could be in a future followup.

tmaroschik · 2023-12-15T13:36:04Z

I verified that the build works on our freebsd 13.2 on amd64. Thanks!

FeynmanZhou · 2023-12-21T09:33:13Z

I verified that the build works on our freebsd 13.2 on amd64. Thanks!

Thanks @tmaroschik for the verification!

Hi @oras-project/oras-cli maintainers, any luck with reviewing or approving this PR?

kranurag7 · 2023-12-21T09:37:18Z

@FeynmanZhou We have one request above about arm64 binaries.

It would be nice to have arm64 binaries as well.

Do you want to proceed with that in this PR? The original issue was only about amd64 binaries, so I skipped other arch.

dfr · 2023-12-21T10:17:06Z

@FeynmanZhou We have one request above about arm64 binaries.

It would be nice to have arm64 binaries as well.

Do you want to proceed with that in this PR? The original issue was only about amd64 binaries, so I skipped other arch.

I'm happy to move forward as-is and look into adding arm64 as a followup.

TerryHowe

/lgtm

SamirPS · 2023-12-29T10:37:02Z

I think it's would better to have all the compatible arch in this PR but else LGTM

qweeah

LGTM.

ORAS CLI will be guaranteed to build on FreeBSD(see Tier 2 in oras-project/oras-www#277).

Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

release artifacts for freebsd

81a5a01

this commit adds support for oras on freebsd os. It adds make target for compiling oras binary on freebsd and updates goreleaser config to release for freebsd as well. Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>

kranurag7 requested review from SteveLasker, TerryHowe, qweeah, sajayantony and shizhMSFT as code owners November 23, 2023 19:40

qweeah changed the title ~~release artifacts for freebsd~~ build(ci): release artifacts for freebsd Nov 24, 2023

TerryHowe approved these changes Dec 6, 2023

View reviewed changes

Merge branch 'main' into kr/add-freebsd-support

c3c2f98

TerryHowe approved these changes Dec 26, 2023

View reviewed changes

Merge branch 'main' into kr/add-freebsd-support

b81d9cc

qweeah approved these changes Jan 2, 2024

View reviewed changes

kranurag7 and others added 2 commits January 12, 2024 19:32

Merge branch 'main' into kr/add-freebsd-support

94c2d95

Merge branch 'main' into kr/add-freebsd-support

3f5424f

qweeah merged commit fbd10af into oras-project:main Jan 25, 2024

qweeah mentioned this pull request Feb 1, 2024

bump: tag and release ORAS CLI v1.2.0-beta.1 #1266

Merged

FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024

build(ci): release artifacts for freebsd (oras-project#1192)

7c74587

Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

Conversation

kranurag7 commented Nov 23, 2023

make targets

goreleaser snapshot

Uh oh!

codecov-commenter commented Nov 23, 2023 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rchincha commented Dec 5, 2023

Uh oh!

dfr commented Dec 6, 2023

Uh oh!

FeynmanZhou commented Dec 6, 2023

Uh oh!

dfr commented Dec 6, 2023

Uh oh!

TerryHowe left a comment

Choose a reason for hiding this comment

Uh oh!

dfr commented Dec 7, 2023

Uh oh!

tmaroschik commented Dec 15, 2023

Uh oh!

FeynmanZhou commented Dec 21, 2023

Uh oh!

kranurag7 commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dfr commented Dec 21, 2023

Uh oh!

TerryHowe left a comment

Choose a reason for hiding this comment

Uh oh!

SamirPS commented Dec 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qweeah left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov-commenter commented Nov 23, 2023 •

edited by codecov Bot

Loading

kranurag7 commented Dec 21, 2023 •

edited

Loading

SamirPS commented Dec 29, 2023 •

edited

Loading