Skip to content

test(e2e): add test for resolve command#1188

Merged
qweeah merged 5 commits into
oras-project:mainfrom
qweeah:resolve-e2e
Nov 22, 2023
Merged

test(e2e): add test for resolve command#1188
qweeah merged 5 commits into
oras-project:mainfrom
qweeah:resolve-e2e

Conversation

@qweeah

@qweeah qweeah commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR adds e2e specs for oras reslove.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread test/e2e/suite/command/resolve.go Outdated
Comment thread test/e2e/suite/command/resolve.go
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01e9cdd) 80.34% compared to head (e362ead) 80.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
- Coverage   80.34%   80.29%   -0.06%     
==========================================
  Files          66       66              
  Lines        3618     3618              
==========================================
- Hits         2907     2905       -2     
- Misses        497      499       +2     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 9ecf303 into oras-project:main Nov 22, 2023
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants