Skip to content

feat: add resolve command#1187

Merged
sajayantony merged 5 commits into
oras-project:mainfrom
sajayantony:resolve
Nov 15, 2023
Merged

feat: add resolve command#1187
sajayantony merged 5 commits into
oras-project:mainfrom
sajayantony:resolve

Conversation

@sajayantony

@sajayantony sajayantony commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This is an update with a test and flags based of PR from @amands98.
@amands98 if you would like to combine these commits I'm more than happy to send a PR to your branch.

  • Resolve command with support for platform output of fully qualified reference -
❯ oras resolve -l localhost:5000/command/artifacts:multi
localhost:5000/command/artifacts@sha256:e2bfc9cc6a84ec2d7365b5a28c6bc5806b7fa581c9ad7883be955a64e3cc034f
❯ oras resolve  localhost:5000/command/artifacts:multi --platform linux/amd64
sha256:9d84a5716c66a1d1b9c13f8ed157ba7d1edfe7f9b8766728b8a1f25c0d9c14c1
❯ oras digest docker.io/library/hello-world:latest
sha256:88ec0acaa3ec199d3b7eaf73588f4518c25f9d34f58ce9a0df68429c5af48e8d

Fixes #907.

@codecov-commenter

codecov-commenter commented Nov 15, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.34%. Comparing base (d7c71e6) to head (561eda6).
⚠️ Report is 486 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
+ Coverage   80.09%   80.34%   +0.25%     
==========================================
  Files          65       66       +1     
  Lines        3572     3618      +46     
==========================================
+ Hits         2861     2907      +46     
  Misses        497      497              
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread test/e2e/suite/command/resolve.go Outdated
@FeynmanZhou

Copy link
Copy Markdown
Member

Thanks @sajayantony . Could you associate the original issue #907 with this PR?

Comment thread cmd/oras/root/resolve.go Outdated
Comment thread cmd/oras/root/resolve.go
Comment thread cmd/oras/root/resolve.go Outdated
Comment thread test/e2e/suite/command/resolve.go Outdated
Comment thread test/e2e/suite/command/resolve.go Outdated
ambahman and others added 5 commits November 15, 2023 06:09
…tput

Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Co-authored-by: Feynman Zhou <feynman@kubesphere.io>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
@TerryHowe

Copy link
Copy Markdown
Member

Closes #907

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sajayantony sajayantony merged commit 01e9cdd into oras-project:main Nov 15, 2023

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Co-authored-by: Feynman Zhou <feynman@kubesphere.io>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add command to get the digest of a tagged manifest without parsing output

7 participants