Skip to content

feat: disable referrers index GC by default#1059

Merged
qweeah merged 3 commits into
oras-project:mainfrom
qweeah:revert
Aug 9, 2023
Merged

feat: disable referrers index GC by default#1059
qweeah merged 3 commits into
oras-project:mainfrom
qweeah:revert

Conversation

@qweeah

@qweeah qweeah commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

Resolves #1041, depends on #1059

qweeah added 2 commits August 9, 2023 06:56
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Aug 9, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.97%. Comparing base (ceb56f8) to head (ab31e6a).
⚠️ Report is 576 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   81.26%   80.97%   -0.29%     
==========================================
  Files          57       56       -1     
  Lines        2914     2891      -23     
==========================================
- Hits         2368     2341      -27     
- Misses        373      375       +2     
- Partials      173      175       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qweeah

qweeah commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

Closing to separate into 2 PRs.

@qweeah qweeah closed this Aug 9, 2023
@qweeah qweeah reopened this Aug 9, 2023
@qweeah qweeah changed the title feat: remove --skip-delete-referrers and disable GC by default feat: disable referrers index GC by default Aug 9, 2023

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing the --skip-delete-referrers

3 participants