chore: improving error log for oras push and oras attach when the annotation file is invalid#1026
Merged
Conversation
TerryHowe
reviewed
Jul 19, 2023
oras push and oras attach when the annotation file is invalidoras push and oras attach when the annotation file is invalid
qweeah
reviewed
Jul 19, 2023
Contributor
|
@1Shubham7 Can you sign the commits via following https://github.com/oras-project/oras/pull/1026/checks?check_run_id=15187109754 |
Contributor
Author
|
figured it out, it should be fine now. @qweeah can you check it out now. |
Signed-off-by: Shubham Singh <shubhammahar1306@gmail.com>
Signed-off-by: Shubham Singh <shubhammahar1306@gmail.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com> Signed-off-by: Shubham Singh <shubhammahar1306@gmail.com>
Signed-off-by: Shubham Singh <shubhammahar1306@gmail.com>
Contributor
Author
|
@qweeah Please have a look at it now. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 81.21% 81.29% +0.07%
==========================================
Files 57 57
Lines 2907 2908 +1
==========================================
+ Hits 2361 2364 +3
+ Misses 373 371 -2
Partials 173 173
|
fix: move stale into .github/workflows (oras-project#1031)
Contributor
Author
|
removing "," because of this. |
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Contributor
Author
|
|
qweeah
reviewed
Jul 24, 2023
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Contributor
Author
|
Maintainers, I am seeing another issue, some errors end with a period (".") while some don't. I had a discussion with @qweeah . Making commits to deal with this. |
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
qweeah
reviewed
Jul 24, 2023
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Contributor
Author
|
it has multiple errors @qweeah . changing it. |
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Signed-off-by: Shubham Singh <116020663+1Shubham7@users.noreply.github.com>
Contributor
Author
|
@qweeah please have a look now. I think its completed. |
Contributor
|
@toddysm Can you help review and confirm the UX in the screen shot? Thanks cc @FeynmanZhou |
sajayantony
approved these changes
Jul 25, 2023
oras push and oras attach when the annotation file is invalidoras push and oras attach when the annotation file is invalid
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
… annotation file is invalid (oras-project#1026) Signed-off-by: Shubham Singh <shubhammahar1306@gmail.com>
This was referenced Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a malformed JSON file is provided via --annotation-file flag, oras used to output
Error: json: cannot unmarshal string into Go value of type map[string]stringPR to improve this to
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1021
screen shot of the final version
Please check the following list: