Skip to content

fix: correct e2e specs and CI check configuration#1023

Merged
TerryHowe merged 1 commit into
oras-project:mainfrom
qweeah:fix-e2e
Jul 18, 2023
Merged

fix: correct e2e specs and CI check configuration#1023
TerryHowe merged 1 commit into
oras-project:mainfrom
qweeah:fix-e2e

Conversation

@qweeah

@qweeah qweeah commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1022

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1023 (7029b16) into main (3092656) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   81.08%   81.21%   +0.13%     
==========================================
  Files          57       57              
  Lines        2907     2907              
==========================================
+ Hits         2357     2361       +4     
+ Misses        376      373       -3     
+ Partials      174      173       -1     

see 1 file with indirect coverage changes

@qweeah

qweeah commented Jul 17, 2023

Copy link
Copy Markdown
Contributor Author

I have validated the change here will prevent false positive result. See https://github.com/qweeah/oras/actions/runs/5572577038/jobs/10178767730#step:6:9075, the error will be returned if the e2e fails.

@qweeah qweeah added this to the v1.1.0 milestone Jul 17, 2023

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit a1d0764 into oras-project:main Jul 18, 2023
qweeah added a commit to qweeah/oras that referenced this pull request Jul 21, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added a commit to qweeah/oras that referenced this pull request Jul 21, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ORAS E2E CI provides false positive result when failing

4 participants