Skip to content

chore: fix lint warning#1001

Merged
qweeah merged 2 commits into
oras-project:mainfrom
kranurag7:error-handling
Jul 11, 2023
Merged

chore: fix lint warning#1001
qweeah merged 2 commits into
oras-project:mainfrom
kranurag7:error-handling

Conversation

@kranurag7

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Ref: #986

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

// cc @qweeah

@qweeah qweeah changed the title add error handling chore: fix lint warning Jul 4, 2023
Comment thread cmd/oras/internal/display/print.go Outdated
Comment thread cmd/oras/internal/option/applier.go Outdated
Comment thread cmd/oras/internal/option/applier.go Outdated
Comment thread cmd/oras/internal/option/packer_test.go Outdated
Comment thread cmd/oras/internal/display/print.go Outdated
Comment thread cmd/oras/internal/option/remote.go Outdated
Comment thread cmd/oras/root/attach.go Outdated
Comment thread cmd/oras/root/discover.go
Comment thread cmd/oras/root/discover.go Outdated
Comment thread internal/cache/target_test.go Outdated
@TerryHowe

Copy link
Copy Markdown
Member

One of these changes is breaking tests. I assume it is one of the error returns that was being ignored before.

Comment thread internal/graph/graph_test.go

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kranurag7 and others added 2 commits July 11, 2023 14:14
Signed-off-by: Anurag <contact.anurag7@gmail.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qweeah qweeah merged commit 5194c2e into oras-project:main Jul 11, 2023
@kranurag7 kranurag7 deleted the error-handling branch July 11, 2023 18:49
qweeah pushed a commit to qweeah/oras that referenced this pull request Jul 21, 2023
Signed-off-by: Anurag <contact.anurag7@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah pushed a commit to qweeah/oras that referenced this pull request Jul 21, 2023
Signed-off-by: Anurag <contact.anurag7@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Anurag <contact.anurag7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants