docs: fix issues and improve the source finder tutorial#924
Merged
Conversation
6ce71b6 to
7cccc72
Compare
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
7cccc72 to
3847932
Compare
tromai
reviewed
Nov 25, 2024
tromai
approved these changes
Nov 25, 2024
tromai
left a comment
Contributor
There was a problem hiding this comment.
Just a small comment at https://github.com/oracle/macaron/pull/924/files#r1855683017
After that is resolved, the PR can be merged.
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues in the source finder tutorial.
It also moves the source finder report JSON schema to
src/macaron/resources/schemastore/, and references it from the tutorial.