chore: add changesets/action for npm release#503
Merged
Conversation
This PR adds changesets/action to the list of GitHub Actions used to publish npm packages. An example project that uses this Action to automate retore-js to automate releases is sigstore/sigstore-js. This PR also fixes a bug for using deploy `github_actions` for build tools. Previously, only the `github_actions` of `pip` build tool was read from `defaults.ini` and used in `build_as_code_check.py`. This fix removes this hard-coded read from `defaults.ini` and makes it applicable to all build tools. Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
reviewed
Oct 5, 2023
tromai
approved these changes
Oct 5, 2023
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR adds `changesets/action` to the list of GitHub Actions used to publish npm packages. An example project that uses this Action to automate releases is `sigstore/sigstore-js`. Note that there is a TODO to also check the `publish` input provided to this Action to improve detection accuracy. This PR also fixes a bug for using the deploy `github_actions` for build tools. Previously, only the `github_actions` of pip build tool was read from `defaults.ini` and used in `build_as_code_check.py`. This fix removes this hard-coded read from `defaults.ini` and makes it applicable to all build tools. Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds changesets/action to the list of GitHub Actions used to publish npm packages. An example project that uses this Action to automate releases is sigstore/sigstore-js. Note that there is a TODO to also check the
publishinput provided to this Action to improve detection accuracy.This PR also fixes a bug for using the deploy
github_actionsfor build tools. Previously, only thegithub_actionsofpipbuild tool was read fromdefaults.iniand used inbuild_as_code_check.py. This fix removes this hard-coded read fromdefaults.iniand makes it applicable to all build tools.