test: improve expectation regex value to better match usage in urllib3#480
Merged
Conversation
Member
|
The scope of the PR and commit title can change to |
Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
7b578ff to
6fc4e78
Compare
behnazh-w
approved these changes
Sep 21, 2023
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
#480) Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #479
Regex value in expectation file is adjusted slightly so as to account for the urllib3 version branch name / tag sometimes starting with a
v.