Skip to content

fix(policy-engine): use component_id instead of repo_id in policy to find the check result#473

Merged
behnazh-w merged 2 commits into
stagingfrom
policy-engine-fix-component-id
Sep 13, 2023
Merged

fix(policy-engine): use component_id instead of repo_id in policy to find the check result#473
behnazh-w merged 2 commits into
stagingfrom
policy-engine-fix-component-id

Conversation

@behnazh-w

Copy link
Copy Markdown
Member

This PR fixes the following bug found as part of integration tests for this PR,.

Bug description: he policy test failed to apply the policy because it was using the repo_id instead the component_id, and the related check result could not be found by the policy engine.

@behnazh-w behnazh-w requested a review from tromai as a code owner September 12, 2023 23:05
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 12, 2023
Comment thread tests/policy_engine/resources/policies/valid/slsa-verifier.dl Outdated
…find the check result

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w force-pushed the policy-engine-fix-component-id branch from 81d0810 to efd2cf5 Compare September 12, 2023 23:40
@behnazh-w behnazh-w changed the base branch from integration-tests/update-micronaut-core-expected-result to staging September 12, 2023 23:41
@behnazh-w behnazh-w merged commit b54690f into staging Sep 13, 2023
@behnazh-w behnazh-w deleted the policy-engine-fix-component-id branch September 21, 2023 04:06
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
…find the check result (#473)

This PR fixes the following bug in the policy engine:

Bug description: the policy test failed to apply the policy because it was using the `repo_id` instead the 
`component_id`, and the related check result could not be found by the policy engine.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants