fix: check if repository is available in provenance available check#467
Merged
Conversation
048cd56 to
d684c29
Compare
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
d684c29 to
d80f49a
Compare
nathanwn
approved these changes
Sep 12, 2023
nathanwn
left a comment
Member
There was a problem hiding this comment.
As we have discussed, I wonder if this issue can be prevented with static type checking. We should revisit this in the future to see if there is a solution that works well with both SQLAlchemy and mypy.
Member
Author
Yes, it would be nice to enforce type checking on repositories, which can be |
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
…467) If a repository is not available for an artifact/analysis target identified by a PURL string, the `mcn_provenance_available_1` check throws an exception. This PR fixes this bug by checking if the repository is available before running the check. Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a repository is not available for an artifact/analysis target identified by a PURL string, the
mcn_provenance_available_1check throws an exception.This PR fixes this bug by checking if the repository is available before running the check.