Skip to content

fix: fix run_macaron.sh script to handle action arguments correctly#461

Merged
nathanwn merged 2 commits into
stagingfrom
460-fix-arg-handling-in-run-macaron-script
Sep 8, 2023
Merged

fix: fix run_macaron.sh script to handle action arguments correctly#461
nathanwn merged 2 commits into
stagingfrom
460-fix-arg-handling-in-run-macaron-script

Conversation

@nathanwn

@nathanwn nathanwn commented Sep 4, 2023

Copy link
Copy Markdown
Member

Closes #460.

Summary

  • Fix the run_macaron.sh script to handle action arguments correctly.
  • Add a test script to check for the arguments that are actually passed to the macaron command in the Macaron container.

Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 4, 2023
@nathanwn nathanwn marked this pull request as ready for review September 4, 2023 09:23
Comment thread Makefile Outdated
Comment thread Makefile Outdated
…tion_tests_docker.sh` script

Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
@nathanwn nathanwn self-assigned this Sep 5, 2023

@tromai tromai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwn nathanwn merged commit 40c2faf into staging Sep 8, 2023
@nathanwn nathanwn deleted the 460-fix-arg-handling-in-run-macaron-script branch September 8, 2023 00:49
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
…#461)

Signed-off-by: Nathan Nguyen <nathan.nguyen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants