Skip to content

Move shap#32

Merged
c-bata merged 20 commits intooptuna:mainfrom
Alnusjaponica:move-shap
Aug 10, 2023
Merged

Move shap#32
c-bata merged 20 commits intooptuna:mainfrom
Alnusjaponica:move-shap

Conversation

@Alnusjaponica
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica commented Jul 6, 2023

Motivation

Progress optuna/optuna#4484 and optuna/optuna#4789.

Description of the changes

Move ShapleyImportanceEvaluator.

@Alnusjaponica
Copy link
Copy Markdown
Contributor Author

Alnusjaponica commented Jul 6, 2023

This PR will need some changes same as #31, so I update this PR after it is merged.

@c-bata
Copy link
Copy Markdown
Member

c-bata commented Jul 7, 2023

@contramundum53 Could you review this PR?

@contramundum53 contramundum53 mentioned this pull request Jul 7, 2023
Merged
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@af6f98c). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage        ?   29.06%           
=======================================
  Files           ?       10           
  Lines           ?       86           
  Branches        ?        0           
=======================================
  Hits            ?       25           
  Misses          ?       61           
  Partials        ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica Alnusjaponica mentioned this pull request Jul 12, 2023
Closed
5 tasks
@Alnusjaponica Alnusjaponica marked this pull request as ready for review July 16, 2023 12:50
@Alnusjaponica
Copy link
Copy Markdown
Contributor Author

Alnusjaponica commented Jul 17, 2023

@contramundum53 Hi, now I made this OR review ready. Could you review this PR?
Note that 99edbcd might need discussion, so please let me know I it is still necessary to use OrderedDict.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 24, 2023

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jul 24, 2023
@github-actions github-actions bot removed the stale Exempt from stale bot labeling. label Jul 25, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 3, 2023

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Aug 3, 2023
@Alnusjaponica
Copy link
Copy Markdown
Contributor Author

Alnusjaponica commented Aug 4, 2023

@contramundum53
This is a kind reminder that I am waiting for your review.

@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented Aug 4, 2023

Sorry for being late 🙇‍♂️
This PR will be merged after v3.3 release.

@contramundum53 contramundum53 removed the stale Exempt from stale bot labeling. label Aug 4, 2023
c-bata
c-bata approved these changes Aug 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata added this to the v3.4.0 milestone Aug 10, 2023
@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label Aug 10, 2023
@c-bata c-bata merged commit 9624522 into optuna:main Aug 10, 2023
@Alnusjaponica Alnusjaponica deleted the move-shap branch August 10, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-bata c-bata c-bata approved these changes

Assignees

No one assigned

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Alnusjaponica @c-bata @codecov-commenter @contramundum53