Skip to content

Move mxnet#31

Merged
gen740 merged 9 commits intooptuna:mainfrom
Alnusjaponica:move-mxnet
Jul 17, 2023
Merged

Move mxnet#31
gen740 merged 9 commits intooptuna:mainfrom
Alnusjaponica:move-mxnet

Conversation

@Alnusjaponica
Copy link
Copy Markdown
Contributor

Motivation

Progress optuna/optuna#4484 and optuna/optuna#4789.

Description of the changes

Move MXNetPruningCallback.

@Alnusjaponica Alnusjaponica mentioned this pull request Jul 6, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@caad7e6). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff           @@
##             main     #31   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       9           
  Lines           ?      39           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      39           
  Partials        ?       0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica Alnusjaponica marked this pull request as ready for review July 6, 2023 15:10
@c-bata c-bata assigned eukaryo and gen740 and unassigned eukaryo Jul 7, 2023
@c-bata
Copy link
Copy Markdown
Member

c-bata commented Jul 7, 2023

@gen740 Could you review this PR?

@github-actions
Copy link
Copy Markdown

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Jul 16, 2023
@Alnusjaponica
Copy link
Copy Markdown
Contributor Author

Alnusjaponica commented Jul 17, 2023

@gen740 This PR is the major blocker of optuna/optuna#4790 and optuna/optuna#4789. Could you review this PR?

Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gen740 gen740 merged commit 3a1afd2 into optuna:main Jul 17, 2023
@Alnusjaponica Alnusjaponica deleted the move-mxnet branch July 17, 2023 02:25
@not522 not522 added this to the v3.3.0 milestone Aug 3, 2023
@not522 not522 added the compatibility Change that breaks compatibility. label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. stale Exempt from stale bot labeling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants