Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4790 +/- ##
==========================================
- Coverage 89.60% 89.57% -0.03%
==========================================
Files 195 195
Lines 14676 14657 -19
==========================================
- Hits 13150 13129 -21
- Misses 1526 1528 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
@gen740 @contramundum53 Could you review this PR? |
Member
contramundum53
left a comment
There was a problem hiding this comment.
LGTM.
I'll give an approval after optuna/optuna-integration#31 is merged.
This was referenced Jul 16, 2023
Contributor
Author
|
@gen740 Thanks for the update. |
Contributor
Author
|
@contramundum53 Hi, there's no blocker for this PR. Could you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Progress #4484 and resolve #4789.
Description of the changes
Move
MXNetPruningCallback, related test and docs.