Move optuna import to TYPE_CHECKING in pruners/_patient.py#6501
Merged
not522 merged 2 commits intooptuna:masterfrom Mar 10, 2026
Merged
Move optuna import to TYPE_CHECKING in pruners/_patient.py#6501not522 merged 2 commits intooptuna:masterfrom
optuna import to TYPE_CHECKING in pruners/_patient.py#6501not522 merged 2 commits intooptuna:masterfrom
Conversation
Part of optuna#6029 `import optuna` is only used in type annotations on the `prune()` method signature. Move it under TYPE_CHECKING and remove redundant string quotes (already guarded by `from __future__ import annotations`). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
optuna import to TYPE_CHECKING in pruners/_patient.pyoptuna import to TYPE_CHECKING in pruners/_patient.py
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6029
Moves
import optuna(used only in type annotations) underif TYPE_CHECKING:inoptuna/pruners/_patient.py.Also removes redundant string quotes from the
prune()method signature sincefrom __future__ import annotationsis already present.