Move JSONSerializable import to TYPE_CHECKING in study/study.py#6490
Merged
not522 merged 1 commit intooptuna:masterfrom Mar 4, 2026
Merged
Conversation
JSONSerializable import to TYPE_CHECKING in study/study.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
JSONSerializableimport inoptuna/study/study.pyunder aTYPE_CHECKINGguard, as it is only used in a type annotation (theparamsparameter of_should_skip_enqueue).This is part of the effort tracked in issue #6029.
Changes
optuna/study/study.py: Movefrom optuna.distributions import JSONSerializableto theif TYPE_CHECKING:blockMotivation
JSONSerializableis only referenced in the type annotation of_should_skip_enqueue(self, params: Mapping[str, JSONSerializable]). Moving it underTYPE_CHECKINGeliminates the runtime import overhead and follows the pattern established for other type-annotation-only imports in the codebase.Testing
No behavioral changes. The annotation is only evaluated by type checkers (e.g., mypy), not at runtime.