refactor: move type-only imports into TYPE_CHECKING in samplers/_grid.py#6466
Merged
c-bata merged 1 commit intooptuna:masterfrom Feb 24, 2026
Merged
Conversation
Move `Mapping`, `Sequence` (from collections.abc), `BaseDistribution`, and `FrozenTrial` into the existing TYPE_CHECKING block since they are only used in type annotations. Fixes optuna#6029
c-bata
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6029
Move
MappingandSequence(fromcollections.abc),BaseDistribution, andFrozenTrialinto the existingTYPE_CHECKINGblock inoptuna/samplers/_grid.py, since all are only used in type annotations and the file already hasfrom __future__ import annotations.Verified with
ruff check optuna/samplers/_grid.py --select TCH— all checks pass.