Skip to content

Move type-hint imports into type-checking block in optuna\terminator\improvement\evaluator.py#6405

Merged
c-bata merged 1 commit intooptuna:masterfrom
Sip4818:type-hint-check-9
Jan 5, 2026
Merged

Move type-hint imports into type-checking block in optuna\terminator\improvement\evaluator.py#6405
c-bata merged 1 commit intooptuna:masterfrom
Sip4818:type-hint-check-9

Conversation

@Sip4818
Copy link
Copy Markdown
Contributor

@Sip4818 Sip4818 commented Dec 29, 2025

Summary

This PR moves type-only imports (FrozenTrial ) into a TYPE_CHECKING block following Optuna’s type-hinting style, in the file optuna\terminator\improvement\evaluator.py

What was changed?

  • Moved type-only imports into a TYPE_CHECKING: block
  • Updated annotations accordingly
  • No functional behavior changed

related to #6029

@Sip4818 Sip4818 closed this Dec 29, 2025
@Sip4818 Sip4818 reopened this Dec 29, 2025
@Sip4818 Sip4818 closed this Dec 29, 2025
@Sip4818 Sip4818 reopened this Dec 29, 2025
@Sip4818 Sip4818 closed this Dec 30, 2025
@Sip4818 Sip4818 reopened this Dec 30, 2025
@Sip4818 Sip4818 force-pushed the type-hint-check-9 branch from f2bef59 to 941d273 Compare January 3, 2026 15:59
Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.

@c-bata c-bata added the code-fix Change that does not change the behavior, such as code refactoring. label Jan 5, 2026
@c-bata c-bata added this to the v4.7.0 milestone Jan 5, 2026
@c-bata c-bata merged commit 3785c1c into optuna:master Jan 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants