Fix invalid StorageTestCase scenarios involving trial state and values#6391
Merged
y0z merged 2 commits intooptuna:masterfrom Dec 25, 2025
Merged
Fix invalid StorageTestCase scenarios involving trial state and values#6391y0z merged 2 commits intooptuna:masterfrom
StorageTestCase scenarios involving trial state and values#6391y0z merged 2 commits intooptuna:masterfrom
Conversation
Member
Author
|
@y0z @kAIto47802 Could you review this PR? |
kAIto47802
requested changes
Dec 24, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR. I left some comments. PTAL 
Co-authored-by: kAIto47802 <115693559+kAIto47802@users.noreply.github.com>
Member
Author
|
@kAIto47802 Thank you for your review. I applied your suggestions. PTAL. |
kAIto47802
approved these changes
Dec 24, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the update! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up #6369
Description of the changes
StorageTestCaseincludes several scenarios that do not align with Optuna’s expected trial lifecycle. These patterns are not valid in normal usage and can cause inconsistencies with the current validation logic.This PR removes or updates the following cases:
FrozenTrial._validate().