Add StorageTestCase class in optuna.testing package#6369
Merged
kAIto47802 merged 3 commits intooptuna:masterfrom Dec 18, 2025
Merged
Add StorageTestCase class in optuna.testing package#6369kAIto47802 merged 3 commits intooptuna:masterfrom
StorageTestCase class in optuna.testing package#6369kAIto47802 merged 3 commits intooptuna:masterfrom
Conversation
62e6591 to
316732f
Compare
StorageTesstCase class in optuna.testing packageStorageTestCase class in optuna.testing package
c9c0614 to
5734614
Compare
y0z
approved these changes
Dec 15, 2025
Member
y0z
left a comment
There was a problem hiding this comment.
LGTM.
I confirmed that all tests work.
test_storages.py .................................................................................................................................................................................................. [ 49%]
...........................................................................................................................................................................................ssss....s..... [100%]
kAIto47802
approved these changes
Dec 18, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR. LGTM
I've checked the all lines and confirmed that there are no missing tests and all tests are identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Third-party storage implementations currently have to copy Optuna’s storage tests (which is written in
tests/storage_tests/test_storage.py). By exposing the sharedStorageTestCaseinoptuna.testing, third-party Optuna storages can run the same test suites, improving consistency and fixing compatibility issues without duplicating test logic.Description of the changes
This PR suggests to exposing
StorageTestCase, so that third-party Optuna storages can write tests like below: