Move type-only imports to TYPE_CHECKING in test_visualizations.py#6380
Merged
not522 merged 3 commits intooptuna:masterfrom Dec 10, 2025
Merged
Move type-only imports to TYPE_CHECKING in test_visualizations.py#6380not522 merged 3 commits intooptuna:masterfrom
TYPE_CHECKING in test_visualizations.py#6380not522 merged 3 commits intooptuna:masterfrom
Conversation
TYPE_CHECKING in test_visualizations.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates one of the files listed in the type-checking cleanup effort. In
tests/visualization_tests/test_visualizations.py, certain imports were used only for type annotations. These should be placed under aTYPE_CHECKINGblock to avoid unnecessary runtime imports, reduce import overhead, prevent potential circular imports, and improve consistency in static type checking across the codebase.Description of the changes
Trial,ObjectiveFuncType) into aTYPE_CHECKINGblock.E501).Related to #6029