updated _terminator_improvement.py for TYPE_CHECKING#6343
Merged
c-bata merged 4 commits intooptuna:masterfrom Nov 26, 2025
Merged
updated _terminator_improvement.py for TYPE_CHECKING#6343c-bata merged 4 commits intooptuna:masterfrom
_terminator_improvement.py for TYPE_CHECKING#6343c-bata merged 4 commits intooptuna:masterfrom
Conversation
Member
|
@kAIto47802 Could you review this PR? |
Member
|
@satyarth7srivastava Thank you for your pull request. Sorry for the extra work, but due to the recent update in the branch protection rule after #6339, could you please merge the latest master branch into yours? 🙏 |
Contributor
Author
|
@c-bata Merged the latest master branch |
kAIto47802
requested changes
Nov 19, 2025
Collaborator
kAIto47802
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I left a comment. PTAL 
Co-authored-by: kAIto47802 <115693559+kAIto47802@users.noreply.github.com>
Contributor
Author
|
@kAIto47802 I have updated the file as per your suggestion and I also had a doubt I asked in the comments there. |
kAIto47802
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR relates to issue #6029
Description of the changes
I've updated
optuna/visualization/matplotlib/_terminator_improvement.pyforTYPE_CHECKING