Use TYPE_CHECKING in optuna/samplers/_random.py#6298
Merged
nabenabe0928 merged 3 commits intooptuna:masterfrom Oct 14, 2025
Merged
Use TYPE_CHECKING in optuna/samplers/_random.py#6298nabenabe0928 merged 3 commits intooptuna:masterfrom
TYPE_CHECKING in optuna/samplers/_random.py#6298nabenabe0928 merged 3 commits intooptuna:masterfrom
Conversation
Move distribution and trial imports into TYPE_CHECKING block to avoid potential circular import issues. Fixes optuna#6029
TYPE_CHECKING in optuna/samplers/_random.py
nabenabe0928
approved these changes
Oct 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6298 +/- ##
==========================================
- Coverage 89.23% 89.11% -0.12%
==========================================
Files 209 209
Lines 13940 13919 -21
==========================================
- Hits 12439 12404 -35
- Misses 1501 1515 +14 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
distributions,BaseDistribution, andFrozenTrialimports intoTYPE_CHECKINGblock to avoid potential circular import issues.Changes
from optuna import distributionsintoTYPE_CHECKINGblockBaseDistributionimport intoTYPE_CHECKINGblockFrozenTrialimport intoTYPE_CHECKINGblockVerification
flake8and confirmed no errorsblackandisortRelated to:
TYPE_CHECKINGif necessary #6029